sco/pokerth
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Added paranoia check before deleting file from the cache directory.

Browse Source
This commit is contained in:
lotodore
2008-05-10 18:43:17 +00:00
parent 17d68255b6
commit 27ccb79edc
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/net/common/clientstate.cpp
+9 -3
View File
@@ -322,7 +322,6 @@ ClientStateSynchronizingServerList::Process(ClientThread &client)
// No more checking needed as this was done before. // No more checking needed as this was done before.
md5ServerListPath /= context.GetServerListUrl().substr(context.GetServerListUrl().find_last_of('/') + 1) + ".md5"; md5ServerListPath /= context.GetServerListUrl().substr(context.GetServerListUrl().find_last_of('/') + 1) + ".md5";
path serverListPath = change_extension(md5ServerListPath, ""); path serverListPath = change_extension(md5ServerListPath, "");
// Compare the md5 sums. // Compare the md5 sums.
string tmpMd5; string tmpMd5;
@@ -346,8 +345,15 @@ ClientStateSynchronizingServerList::Process(ClientThread &client)
else else
{ {
// Download new server list. // Download new server list.
remove(serverListPath); // Paranoia check before removing the file, we do not want to delete wrong files.
client.SetState(ClientStateStartServerListDownload::Instance()); path tmpPath(serverListPath);
if (path(context.GetCacheDir()) == tmpPath.remove_leaf())
{
remove(serverListPath);
client.SetState(ClientStateStartServerListDownload::Instance());
}
else
throw ClientException(__FILE__, __LINE__, ERR_SOCK_INVALID_SERVERLIST_URL, 0);
} }
} }