CppCheck fixes.

src/chatcleaner/cleanerconfig.cpp

@@ -18,7 +18,7 @@
  *   59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.             *
  ***************************************************************************/
 #include "cleanerconfig.h"
-#include "tinyxml.h"
+#include <tinyxml.h>
 
 #define MODUS 0711
 

src/config/configfile.cpp

@@ -20,7 +20,7 @@
 #include "configfile.h"
 #include <qttoolsinterface.h>
 #include <core/loghelper.h>
-#include "tinyxml.h"
+#include <tinyxml.h>
 
 #define MODUS 0711
 

src/gui/qt/gametable/gametableimpl.cpp

@@ -50,7 +50,7 @@
 
 #include <net/socket_msg.h>
 
-#include "math.h"
+#include <cmath>
 
 #define FORMATLEFT(X) "<p align='center'>(X)"
 #define FORMATRIGHT(X) "(X)</p>"

src/gui/qt/joinnetworkgamedialog/joinnetworkgamedialogimpl.cpp

@@ -20,7 +20,7 @@
 #include "joinnetworkgamedialogimpl.h"
 #include "session.h"
 #include "configfile.h"
-#include "tinyxml.h"
+#include <tinyxml.h>
 #include <net/socket_startup.h>
 
 using namespace std;

src/gui/qt/styles/carddeckstylereader.h

@@ -20,7 +20,7 @@
 #ifndef CARDDECKSTYLEREADER_H
 #define CARDDECKSTYLEREADER_H
 
-#include "tinyxml.h"
+#include <tinyxml.h>
 #include "configfile.h"
 #include <string>
 #include <QtCore>

src/gui/qt/styles/gametablestylereader.h

@@ -20,7 +20,7 @@
 #ifndef GAMETABLESTYLEREADER_H
 #define GAMETABLESTYLEREADER_H
 
-#include "tinyxml.h"
+#include <tinyxml.h>
 #include "configfile.h"
 #include "gametableimpl.h"
 #include "mymessagedialogimpl.h"

src/net/common/chatcleanermanager.cpp

@@ -31,7 +31,8 @@ using boost::asio::ip::tcp;
 
 
 ChatCleanerManager::ChatCleanerManager(ChatCleanerCallback &cb, boost::shared_ptr<boost::asio::io_service> ioService)
-: m_callback(cb), m_ioService(ioService), m_connected(false), m_curRequestId(0), m_recvBufUsed(0)
+: m_callback(cb), m_ioService(ioService), m_connected(false), m_curRequestId(0), m_serverPort(0), m_useIpv6(false),
+  m_recvBufUsed(0)
 {
 	m_resolver.reset(
 		new boost::asio::ip::tcp::resolver(*m_ioService));

src/net/common/clientstate.cpp

@@ -35,7 +35,7 @@
 #include <game.h>
 #include <playerinterface.h>
 
-#include "tinyxml.h"
+#include <tinyxml.h>
 #include "zlib.h"
 #include <boost/bind.hpp>
 #include <boost/iostreams/filtering_streambuf.hpp>

src/net/common/sessionmanager.cpp

@@ -92,7 +92,7 @@ SessionManager::GetSessionById(SessionId id) const
 }
 
 SessionWrapper
-SessionManager::GetSessionByPlayerName(const string playerName) const
+SessionManager::GetSessionByPlayerName(const string &playerName) const
 {
 	SessionWrapper tmpSession;
 	boost::recursive_mutex::scoped_lock lock(m_sessionMapMutex);

src/net/sessionmanager.h

@@ -54,7 +54,7 @@ public:
 	bool RemoveSession(SessionId session);
 
 	SessionWrapper GetSessionById(SessionId id) const;
-	SessionWrapper GetSessionByPlayerName(const std::string playerName) const;
+	SessionWrapper GetSessionByPlayerName(const std::string &playerName) const;
 	SessionWrapper GetSessionByUniquePlayerId(unsigned uniqueId, bool initSessions = false) const;
 
 	PlayerDataList GetPlayerDataList() const;