Fixing issue #138: No longer throw an exception if the server list is invalid, because the server list is always invalid in network games.

src/net/common/clientstate.cpp

@@ -174,6 +174,9 @@ void
 ClientStateStartServerListDownload::Enter(boost::shared_ptr<ClientThread> client)
 {
 	path tmpServerListPath(client->GetCacheServerListFileName());
+	if (tmpServerListPath.empty())
+		throw ClientException(__FILE__, __LINE__, ERR_SOCK_INVALID_SERVERLIST_URL, 0);
+
 	if (exists(tmpServerListPath)) {
 		// Download the current server list once a day.
 		// If the previous file is older than one day, delete it.

src/net/common/clientthread.cpp

@@ -936,15 +936,16 @@ ClientThread::GetContext()
 string
 ClientThread::GetCacheServerListFileName()
 {
+	string fileName;
 	path tmpServerListPath(GetContext().GetCacheDir());
 	string serverListUrl(GetContext().GetServerListUrl());
 	// Retrieve the file name from the URL.
 	size_t pos = serverListUrl.find_last_of('/');
-	if (GetContext().GetCacheDir().empty() || serverListUrl.empty() || pos == string::npos || ++pos >= serverListUrl.length()) {
+	if (!GetContext().GetCacheDir().empty() && !serverListUrl.empty() && pos != string::npos && ++pos < serverListUrl.length()) {
-		throw ClientException(__FILE__, __LINE__, ERR_SOCK_INVALID_SERVERLIST_URL, 0);
+		tmpServerListPath /= serverListUrl.substr(pos);
+		fileName = tmpServerListPath.directory_string();
 	}
-	tmpServerListPath /= serverListUrl.substr(pos);
+	return fileName;
-	return tmpServerListPath.directory_string();
 }
 
 void