Merge pull request #299 from jwakely/boost-fstream-ambiguity

Qualify std::ifstream and std::ofstream
This commit is contained in:
lotodore
2015-11-29 16:38:29 +01:00
7 changed files with 13 additions and 13 deletions
+2 -2
View File
@@ -61,7 +61,7 @@ using namespace std;
using namespace boost::filesystem; using namespace boost::filesystem;
struct AvatarFileState { struct AvatarFileState {
ifstream inputStream; std::ifstream inputStream;
}; };
AvatarManager::AvatarManager(bool useExternalServer, const std::string &externalServerAddress, AvatarManager::AvatarManager(bool useExternalServer, const std::string &externalServerAddress,
@@ -371,7 +371,7 @@ AvatarManager::StoreAvatarInCache(const MD5Buf &md5buf, AvatarFileType avatarFil
path tmpPath(cacheDir); path tmpPath(cacheDir);
tmpPath /= (md5buf.ToString() + ext); tmpPath /= (md5buf.ToString() + ext);
string fileName(tmpPath.file_string()); string fileName(tmpPath.file_string());
ofstream o(fileName.c_str(), ios_base::out | ios_base::binary | ios_base::trunc); std::ofstream o(fileName.c_str(), ios_base::out | ios_base::binary | ios_base::trunc);
if (!o.fail()) { if (!o.fail()) {
o.write((const char *)data, size); o.write((const char *)data, size);
o.close(); o.close();
+3 -3
View File
@@ -67,7 +67,7 @@ void
internal_log_err(const string &msg) internal_log_err(const string &msg)
{ {
if (!g_logFile.empty()) { if (!g_logFile.empty()) {
ofstream o(g_logFile.c_str(), ios_base::out | ios_base::app); std::ofstream o(g_logFile.c_str(), ios_base::out | ios_base::app);
if (!o.fail()) { if (!o.fail()) {
o << second_clock::local_time() << " ERR: " << msg; o << second_clock::local_time() << " ERR: " << msg;
o.flush(); o.flush();
@@ -80,7 +80,7 @@ internal_log_msg(const std::string &msg)
{ {
if (g_logLevel) { if (g_logLevel) {
if (!g_logFile.empty()) { if (!g_logFile.empty()) {
ofstream o(g_logFile.c_str(), ios_base::out | ios_base::app); std::ofstream o(g_logFile.c_str(), ios_base::out | ios_base::app);
if (!o.fail()) if (!o.fail())
o << second_clock::local_time() << " MSG: " << msg; o << second_clock::local_time() << " MSG: " << msg;
} }
@@ -92,7 +92,7 @@ internal_log_level(const std::string &msg, int logLevel)
{ {
if (g_logLevel >= logLevel) { if (g_logLevel >= logLevel) {
if (!g_logFile.empty()) { if (!g_logFile.empty()) {
ofstream o(g_logFile.c_str(), ios_base::out | ios_base::app); std::ofstream o(g_logFile.c_str(), ios_base::out | ios_base::app);
if (!o.fail()) if (!o.fail())
o << second_clock::local_time() << " OUT: " << msg; o << second_clock::local_time() << " OUT: " << msg;
} }
+2 -2
View File
@@ -308,8 +308,8 @@ ClientStateReadingServerList::Enter(boost::shared_ptr<ClientThread> client)
// Unzip the file using zlib. // Unzip the file using zlib.
try { try {
ifstream inFile(zippedServerListPath.directory_string().c_str(), ios_base::in | ios_base::binary); std::ifstream inFile(zippedServerListPath.directory_string().c_str(), ios_base::in | ios_base::binary);
ofstream outFile(xmlServerListPath.directory_string().c_str(), ios_base::out | ios_base::trunc); std::ofstream outFile(xmlServerListPath.directory_string().c_str(), ios_base::out | ios_base::trunc);
boost::iostreams::filtering_streambuf<boost::iostreams::input> in; boost::iostreams::filtering_streambuf<boost::iostreams::input> in;
in.push(boost::iostreams::zlib_decompressor()); in.push(boost::iostreams::zlib_decompressor());
in.push(inFile); in.push(inFile);
+2 -2
View File
@@ -1695,7 +1695,7 @@ void
ClientThread::ReadSessionGuidFromFile() ClientThread::ReadSessionGuidFromFile()
{ {
string guidFileName(GetContext().GetCacheDir() + TEMP_GUID_FILENAME); string guidFileName(GetContext().GetCacheDir() + TEMP_GUID_FILENAME);
ifstream guidStream(guidFileName.c_str(), ios::in | ios::binary); std::ifstream guidStream(guidFileName.c_str(), ios::in | ios::binary);
if (guidStream.good()) { if (guidStream.good()) {
std::vector<char> tmpGuid(CLIENT_GUID_SIZE); std::vector<char> tmpGuid(CLIENT_GUID_SIZE);
guidStream.read(&tmpGuid[0], CLIENT_GUID_SIZE); guidStream.read(&tmpGuid[0], CLIENT_GUID_SIZE);
@@ -1707,7 +1707,7 @@ void
ClientThread::WriteSessionGuidToFile() const ClientThread::WriteSessionGuidToFile() const
{ {
string guidFileName(GetContext().GetCacheDir() + TEMP_GUID_FILENAME); string guidFileName(GetContext().GetCacheDir() + TEMP_GUID_FILENAME);
ofstream guidStream(guidFileName.c_str(), ios::out | ios::trunc | ios::binary); std::ofstream guidStream(guidFileName.c_str(), ios::out | ios::trunc | ios::binary);
if (guidStream.good()) { if (guidStream.good()) {
guidStream.write(GetContext().GetSessionGuid().c_str(), GetContext().GetSessionGuid().size()); guidStream.write(GetContext().GetSessionGuid().c_str(), GetContext().GetSessionGuid().size());
} }
+1 -1
View File
@@ -96,7 +96,7 @@ DownloaderThread::Main()
// Previous download was finished. // Previous download was finished.
if (m_curDownloadData) { if (m_curDownloadData) {
path filepath(m_curDownloadData->filename); path filepath(m_curDownloadData->filename);
ifstream instream(filepath.file_string().c_str(), ios_base::in | ios_base::binary); std::ifstream instream(filepath.file_string().c_str(), ios_base::in | ios_base::binary);
// Find out file size. // Find out file size.
// Not fully portable, but works on win/linux/mac. // Not fully portable, but works on win/linux/mac.
instream.seekg(0, ios_base::beg); instream.seekg(0, ios_base::beg);
+1 -1
View File
@@ -161,7 +161,7 @@ main(int argc, char *argv[])
pidFile = tmpPidPath.directory_string(); pidFile = tmpPidPath.directory_string();
} }
{ {
ofstream pidStream(pidFile.c_str(), ios_base::out | ios_base::trunc); std::ofstream pidStream(pidFile.c_str(), ios_base::out | ios_base::trunc);
if (!pidStream.fail()) if (!pidStream.fail())
pidStream << getpid(); pidStream << getpid();
else else
+2 -2
View File
@@ -59,8 +59,8 @@ main(int argc, char *argv[])
return 2; return 2;
} }
try { try {
ifstream inFile(inputFilePath.directory_string().c_str(), ios_base::in); std::ifstream inFile(inputFilePath.directory_string().c_str(), ios_base::in);
ofstream outFile(outputFilePath.directory_string().c_str(), ios_base::out | ios_base::binary); std::ofstream outFile(outputFilePath.directory_string().c_str(), ios_base::out | ios_base::binary);
boost::iostreams::filtering_streambuf<boost::iostreams::output> out; boost::iostreams::filtering_streambuf<boost::iostreams::output> out;
out.push(boost::iostreams::zlib_compressor()); out.push(boost::iostreams::zlib_compressor());
out.push(outFile); out.push(outFile);