Fixing nasty bugs found with the help of cppcheck. This should be backported to the current server asap.

src/net/common/clientthread.cpp

@@ -1224,10 +1224,12 @@ ClientThread::RemoveDisconnectedPlayers()
 	// This should only be called between hands.
 	if (m_game)
 	{
-		PlayerListIterator it;
+		PlayerList tmpList(m_game->getSeatsList());
-		for (it = m_game->getSeatsList()->begin(); it != m_game->getSeatsList()->end(); it++)
+		PlayerListIterator i = tmpList->begin();
+		PlayerListIterator end = tmpList->end();
+		while (i != end)
 		{
-			boost::shared_ptr<PlayerInterface> tmpPlayer = *it;
+			boost::shared_ptr<PlayerInterface> tmpPlayer = *i;
 			if (tmpPlayer->getMyActiveStatus())
 			{
 				// If a player is not in the player data list, it was disconnected.
@@ -1237,6 +1239,7 @@ ClientThread::RemoveDisconnectedPlayers()
 					tmpPlayer->setMyActiveStatus(false);
 				}
 			}
+			++i;
 		}
 	}
 }

src/net/common/servergame.cpp

@@ -847,8 +847,9 @@ ServerGame::RemoveDisconnectedPlayers()
 	// This should only be called between hands.
 	if (m_game)
 	{
-		PlayerListIterator i = m_game->getSeatsList()->begin();
+		PlayerList tmpList(m_game->getSeatsList());
-		PlayerListIterator end = m_game->getSeatsList()->end();
+		PlayerListIterator i = tmpList->begin();
+		PlayerListIterator end = tmpList->end();
 		while (i != end)
 		{
 			boost::shared_ptr<PlayerInterface> tmpPlayer = *i;