Fix buffer overflow in libircclient (concerning DCC, which was unused, so this is just to satisfy pedantic compilers :-) ).

2009-03-16 22:13:55 +00:00
parent 3073cf03f0
commit 64ec42aaa3
1 changed files with 2 additions and 1 deletions
@@ -531,7 +531,8 @@ static int libirc_new_dcc_session (irc_session_t * session, unsigned long ip, un

 		memset (&saddr, 0, sizeof(saddr));
 		saddr.sin_family = AF_INET;
-		memcpy (&saddr.sin_addr, &session->local_addr, sizeof(session->local_addr));
+		// NOTE: This will not work with IPv6!
+		memcpy (&saddr.sin_addr, &session->local_addr, sizeof(struct in_addr));
        saddr.sin_port = htons (0);

 		if ( bind (dcc->sock, (struct sockaddr *) &saddr, sizeof(saddr)) < 0 )